Allow out-of-crate preprocessed column definitions #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yoichi-nexus
force-pushed
the
prep-trait
branch
from
8c03507 to
cec714b
Compare
|
I got early feedbacks. I want to give it another try
This would eliminate the dynamic dispatch business, and will be a straightforward generalization of the current codebase. |
Didn't quite work out. I am adding tons of type arguments everywhere. At the moment this PR is still my best try. |
|
are we going to have a function for every backend? Code quote: fn gen_preprocessed_column_cpu(
&self,
) -> CircleEvaluation<CpuBackend, BaseField, BitReversedOrder>;
fn gen_preprocessed_column_simd(
&self,
) -> CircleEvaluation<SimdBackend, BaseField, BitReversedOrder>; |
There was a problem hiding this comment.
Reviewed 3 of 14 files at r1, all commit messages.
Reviewable status: 3 of 14 files reviewed, 1 unresolved discussion (waiting on @yoichi-nexus)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an enum
PreprocessedColumnand introduces a traitPreprocessedColumnOps. The enum values are turned into trait implementations.Motivation
Before this PR, when a
stwouser wanted a new column in the preprocessed column, they had to changestwocodebase and add a value inPreprocessedColumnenum.After this PR, they can implement
PreprocessedColumnOpsin their own crate, without touchingstwocodebase.